search

FHIR / sushi

SUSHI (aka "SUSHI Unshortens Short Hand Inputs") is a reference implementation command-line interpreter/compiler for FHIR Shorthand (FSH).
Apache License 2.0
145 stars 44 forks source link

Produce correct FSH for concept CaretValueRules on ValueSets #1385

Closed mint-thompson closed 11 months ago

mint-thompson commented 11 months ago

Completes task CIMPL-1199.

When a CaretValueRule on a ValueSet has a concept as its path, the system is also included. However, this is not the case when the rule is on a CodeSystem. CaretValueRule should produce FSH that is correct in both cases.

My strategy here was to try to use pathArray a little more consistently between CodeSystems and ValueSets. In both cases, the # will be included in this array's elements. ValueSets include the system system#code and CodeSystems don't #code. This means needing to trim off the leading # in some situations when exporting CodeSystems.

cmoesel commented 11 months ago

This seems good, but since it hit a variety of areas in the codebase, I'm running a regression. @mint-thompson - If you already ran one, let me know. Also, it looks like there is a conflict that needs to be resolved.

mint-thompson commented 11 months ago

The latest update fixes the problems in the regression, as well as correcting some related issues that were popping up involving codes that start with a double-quote " character.

cmoesel commented 11 months ago

I ran a full regression Monday afternoon and got back some changes. I think they might be related to this branch not being up to date w/ master though -- so I'm going to synch the branch and run regression on just the projects that had differences in my last run.