Prior to this PR, when running a regression, if the code that compares repos threw an error, it crashed the regression script. This fix catches the error, marks it as such, and generates the diff files with a message indicating that there was an error comparing the repos.
I don't if this particular error is an idiosyncracy on my system or reproducible on other systems. You can try to reproduce it and see if my PR fixes it.
Checkout the master branch and run npm install
Run npm run regression -- run -r FHIR/sql-on-fhir-v2#master
It may crash with something like: _Unexpected error: [Error: ELOOP: too many symbolic links encountered, stat '/path/to/sushi/master/regression/output/FHIR-sql-on-fhir-v2-master/sushi-gh-master/testreport/public/implementations.json']
Now checkout this PR branch
Run npm run regression -- run -r FHIR/sql-on-fhir-v2#master
It should report the status of the compare as ERROR in the CLI
Click the diff links in the regression report and confirm they contain the error
Prior to this PR, when running a regression, if the code that compares repos threw an error, it crashed the regression script. This fix catches the error, marks it as such, and generates the diff files with a message indicating that there was an error comparing the repos.
I don't if this particular error is an idiosyncracy on my system or reproducible on other systems. You can try to reproduce it and see if my PR fixes it.
npm installnpm run regression -- run -r FHIR/sql-on-fhir-v2#masternpm run regression -- run -r FHIR/sql-on-fhir-v2#master