Closed mint-thompson closed 6 months ago
One other thing I noticed is that the
ElementDefinition.assignFshCode
tests take a lot longer to run on this branch than on master.
Okay, so the good news is, it's not just you: this is also happening for me. This makes me think it's worth investigating, so I'll... investigate.
I've made some small updates to comments. There's also a new issue for yet another bug discovered when investigating the differences in output on this branch. Next is investigating assignFshCode
.
Fixes #1426 and completes task CIMPL-1242.
Instance export remains one of SUSHI's most time-consuming operations. This PR includes several changes that aim to reduce the amount of time needed to export Instances.
As examples of the benefits of these changes, here are a few selected repos from the regression set, with run times for SUSHI 3.8.0 and for this change set. These times are wall-clock times from my personal system, which are not perfectly accurate measurements of performance. However, I feel that the magnitude of the time reductions are significant.
In the regression set for this PR, some changes appear. However, these are due to existing bugs that were revealed by the changes in this PR. Two issues have been added to the SUSHI backlog for these bugs: https://standardhealthrecord.atlassian.net/browse/CIMPL-1248 and https://standardhealthrecord.atlassian.net/browse/CIMPL-1249