FHNW-IVGI / Geoharvester

NDGI Project Geoharvester
10 stars 1 forks source link

[Backend, request] API requirements #27

Closed p1d1d1 closed 1 year ago

p1d1d1 commented 1 year ago

{ "id": 1234, "provider": "", "title": "", "name": "", "preview": "", "tree": "", "group": "", "abstract": "", "keywords": "", "legend": "", "contact": "", "endpoint": "", "metadata": "", "service": "", "maxZoom": 5, "centerLat": 1234, "centerLon": 1234, "bbox": "", "category": "" }

FStriewski commented 1 year ago

Pagination For what reason(s) would you require server-side pagination? The search as-is is sufficently fast. Clicking through a lot of pages tends to frustrates users and usually means that a sufficent result has not be achieved by the combination of search terms (or our algorithm). I would suggest to keep it frontend only unless there is a good reason for it - also to save on development time.

getAll This is a very costly operation so I would advise against being able to call that endpoint on a "blank" search without query parameters. For a full database dump we should move that functionality behind specific UI elements.

fields in table Bit of a UI challenge with the available space and the current MUI table. We probably cannot display all fields at once (as seen in earlier experiments) and would need to the decide on the most important ones (for the user to decide which results are relevant). We could maybe add an "expand" feature, so that you get the remaining fields when clicking on a table row. This could, for instance, be the more technical and less human readable properties (like coordinates, zoom level and such). Depends on the use case / user requirements.

p1d1d1 commented 1 year ago

@FStriewski

FStriewski commented 1 year ago

Yes, you're right, the API will return all values except for "update". I'll move pagination to a its own ticket and will handle it separately. All others features should be easy enough to implement right away, so that they'll be available for the 17th.

I noticed you renamed some of the fields, e.g. "owner" to "provider" and so on. Is that definete? In that case we should adjust the naming in both, the scraper (output) and the schema.

FStriewski commented 1 year ago

Changes, except for pagination, implemented with this MR: https://github.com/FHNW-IVGI/Geoharvester/pull/32