FINNGEN / CohortOperations2

Other
0 stars 0 forks source link

Display of names in cohorts export #75

Closed siirtola closed 2 months ago

siirtola commented 3 months ago

Could we have it display as:

alias (long cohort name)

rather than

alias -- long cohort name

my concern is that the long dash looks like a minus mathematical sign

Image

javier-gracia-tabuenca-tuni commented 3 months ago

is not a - is some emoji https://emojipedia.org/minus

the string is parsed at some point to separate alias from long name, that was the easiest way, if () or other characters, appear in the long name, make it harder to make this separation eg allias (long name with (brakets))

not impossible to do, but i chose the fastest solution at that point, i can change it, but may not be priority, or if you want to change i'm happy to accept the pr

siirtola commented 3 months ago

OK, I made the change, but didn't spot the parsing problem! Luckily, I didn't send the pr yet.

javier-gracia-tabuenca-tuni commented 2 months ago

ok, I remembered wrong, this change does not break the code. you can make it, but has to happen in all the places not only in the export

It is more that, i was thinking that may be confusing to use () if these are used in the name

siirtola commented 2 months ago

Yes, that would be really confusing. Could we prevent using some letter in the name? Like colon or semicolon?

shortname : longname