search

FINNGEN / META_ANALYSIS

Tools for doing x way meta-analysis
MIT License
6 stars 14 forks source link

Harmonization messes up column ordering #39

Closed juhaa closed 3 years ago

juhaa commented 3 years ago

Harmonization script messes up column ordering for extra_cols: https://github.com/FINNGEN/META_ANALYSIS/blob/a252f8497775b160cb8ebacbf2ca44a00a93a0ff/scripts/harmonize.py#L150-L153 Probably fixed by changing to OrderedDict

juhaa commented 3 years ago

...or just update Python in docker to 3.7+ where dicts are ordered

Fedja commented 3 years ago

if the idea here is to have all other than required columns spit out after the required columns in otherwise original order then just don't use the h_idx in the list comprehension but just the list you get after header line split()

juhaa commented 3 years ago

if the idea here is to have all other than required columns spit out after the required columns in otherwise original order then just don't use the h_idx in the list comprehension but just the list you get after header line split()

Or that yes.