search

FINNGEN / autoreporting

MIT License
0 stars 1 forks source link

Update readme: WDL documentation #141

Closed Lipastomies closed 4 years ago

Lipastomies commented 4 years ago

Adds some instructions for using the WDL pipeline. Comments welcome.

Lipastomies commented 4 years ago

Looks good! To make it even clearer, which parameters need to be changed by the user, you could rank them up high in the file, and in the table that describes the parameters. E.g.

    "autoreporting.input_array_file": "gs://r5_data/autoreporting/r5_phenotype_array_2020_03_25.tsv",
    "autoreporting.sign_treshold":5e-8,
    "autoreporting.ld_r2":0.05,

Thank you for the review! That's a great idea about the table ranking. I think what would be also good is to order the parameters in the same order in the JSON files - I've been postponing their organization for quite a while, but maybe it is time for a spring (/summer) cleaning.