FINNGEN / autoreporting

MIT License
0 stars 1 forks source link

credible_set_min_r2 wrong #171

Closed Lipastomies closed 3 years ago

Lipastomies commented 3 years ago

credible_set_min_r2 shows the minimum value of r2 for cs variants in the report. This means that for bad credible sets, this value will be 1, since the bad vars are filtered out.

It should be either just cs_min_r2 from finemapping, or `min(cs_min_r2,min(cs["r2_to_lead"])). Probably would be better to have it be cs_min_r2 and then people can calculate the existing cs min r2 themselves if they want.

Lipastomies commented 3 years ago

Fixed