search

FINNSEEFLY / Darcula-Theme-VS-2022

Theme extension for Visual Studio 2022 based on "Darcula Theme" from rokoroku and inspired by the original "Darcula" from JetBrains.
MIT License
31 stars 11 forks source link

Type and variable names are the same colour #19

Open spapaseit opened 1 year ago

spapaseit commented 1 year ago

Let me start off by saying thank you for your hard work on this incredible theme, it keeps getting better and better!

I just wanted to add a request: To differentiate the colour of Type and Variable names, like in the VS Code version of the Darcula theme.

Here is a side by side of the same file in VS2022 and VS Code: image

As you can see, the colour differentiation makes it easier to see what's what at a glance.

Thanks again

FINNSEEFLY commented 1 year ago

Hi

Initially, I tried to make the theme as similar as possible to Darcula from Rider.

Darcula theme in Rider 2022.3.2 ![image](https://user-images.githubusercontent.com/43048277/219977946-d69c4e7c-71d0-4961-96a6-834ef6ecbc6a.png)

I fully understand the wish to add some kind of highlighting for classes. In my daily work, I use a slightly modified Rider Dark theme (I made interfaces different from classes).

Rider Dark theme (modified) in Rider 2022.3.2 ![image](https://user-images.githubusercontent.com/43048277/219978294-aec82fa2-aa4a-4e49-8280-5f7f48ccac3e.png)

I also like the highlighting offered in Fleet.

Fleet ![image](https://user-images.githubusercontent.com/43048277/219978415-97ce2222-4806-4402-a63e-e3ac6c80a811.png)

The last two examples differ from each other not only in colors, but also in the presence or absence of their own colors, for example, for private class fields. However, speaking specifically about Darcula, it looks like some feature of this theme. This theme came from IntelliJ IDEA, where it has been in this form for years and many Java programmers have used it in this form. Thus, if I change this, in our opinion, inconvenient feature, it may be an unpleasant surprise for those who are already used to this theme and were looking for it in this form in order to switch to C# without unnecessary discomfort. At the same time, I understand that this feature does not contribute to productive work.

I will definitely come back to this when I start working on the next version. I also think it's a good option to just add the version with the changed highlighting to the extension as a separate theme, and leave the old one as it is.

I would be grateful if you could share a link to the Darcula version you mentioned.

spapaseit commented 1 year ago

Thanks for the detailed explanation, I totally understand the motivation.

Interestingly, rokoroku decided to modify the theme when he created the VS Code version of the Darcula theme "to match look and feel with VS Code IDE.", as he states in the README.

I also think it's a good option to just add the version with the changed highlighting to the extension as a separate theme

I like the idea :)

Thanks yet again for the time and effort you spend on this theme!