search

FINRAOS / DataGenerator

DataGenerator is a Java library for systematically producing large volumes of data. DataGenerator frames data production as a modeling problem, with a user providing a model of dependencies among variables and the library traversing the model to produce relevant data sets.
http://finraos.github.io/DataGenerator
Apache License 2.0
161 stars 171 forks source link

Update DG_Boundary.rst #263

Closed leeny324 closed 8 years ago

leeny324 commented 8 years ago

Fixed the decimal example to remove positive values. Added documentation for decimal, varchar, and date.

mibrahim commented 8 years ago

@leeny324 can you check why is the test failing ? can you check plz

leeny324 commented 8 years ago

Looking into this. I didn't (mean to) make any code changes, so not sure why core build failed.

leeny324 commented 8 years ago

It looks like the failure is coming from DataConsumerTest.java. Not sure why this is coming up with my commit. Can someone look into this?

testSendRequestFromWriter(org.finra.datagenerator.consumer.DataConsumerTest) Time elapsed: 5.015 sec <<< FAILURE! java.lang.AssertionError: expected:<5> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.finra.datagenerator.consumer.DataConsumerTest.testSendRequestFromWriter(DataConsumerTest.java:260) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) ... ... ...

Results :

Failed tests: testSendRequestSync(org.finra.datagenerator.consumer.DataConsumerTest): expected:<[test1]> but was:<[]> testSendRequestNoHandling(org.finra.datagenerator.consumer.DataConsumerTest): expected:<[test1]> but was:<[]> testSendRequestFromWriter(org.finra.datagenerator.consumer.DataConsumerTest): expected:<5> but was:<0>

Tests run: 192, Failures: 3, Errors: 0, Skipped: 0

leeny324 commented 8 years ago

Ran all tests a few more times and am seeing that they are now passing. Maybe just flaky test execution.

bryantrobbins commented 8 years ago

These are only doc changes. Will merge and deal with flaky test later...

Thanks Nate!

SamerAdra commented 8 years ago

I have a dependent project that builds this from source, which build is failing due to this unit test flakiness. I will ignore it in my fork for now, but in the future I would appreciate, if we can't fix the unit tests, to mark them as ignore so we would still have a working build. Better yet if we could hold off on merging a PR until the tests all pass consistently.

mibrahim commented 8 years ago

Which unit tests are failing ?

On Mon, Dec 28, 2015, 3:14 PM SamerAdra notifications@github.com wrote:

I have a dependent project that builds this from source, which build is failing due to this unit test flakiness. I will ignore it in my fork for now, but in the future I would appreciate, if we can't fix the unit tests, to mark them as ignore so we would still have a working build. Better yet if we could hold off on merging a PR until the tests all pass consistently.

— Reply to this email directly or view it on GitHub https://github.com/FINRAOS/DataGenerator/pull/263#issuecomment-167644788 .

SamerAdra commented 8 years ago

NegativeBoundHiveDateTest: lowerBoundTest2 (expected:<201[6-01-01]> but was:<201[5-12-29]>) DataConsumerTest: testSendRequestNoHandling, testSendRequestSync, testSendRequestFromWriter

Brijeshrpatel9 commented 8 years ago

Same Test is failing in my pull request.

leeny324 commented 8 years ago

I know what's wrong with the test and will fix it.

On Tuesday, December 29, 2015, Brijesh Patel notifications@github.com wrote:

Same Test is failing in my pull request.

— Reply to this email directly or view it on GitHub https://github.com/FINRAOS/DataGenerator/pull/263#issuecomment-167829157 .

leeny324 commented 8 years ago

Fixed the code and created a PR.

On Tuesday, December 29, 2015, Nathaniel Lee nathaniel.lee289@gmail.com wrote:

I know what's wrong with the test and will fix it.

On Tuesday, December 29, 2015, Brijesh Patel <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Same Test is failing in my pull request.

— Reply to this email directly or view it on GitHub https://github.com/FINRAOS/DataGenerator/pull/263#issuecomment-167829157 .