FINRAOS / JTAF-ExtWebDriver

Extensions for WebDriver is an enhancement to the powerful WebDriver API, with robust features that keep your browser automation running smoothly. It includes a widget library, improved session management and extended functions over the existing WebDriver API.
http://finraos.github.io/JTAF-ExtWebDriver
Apache License 2.0
26 stars 49 forks source link

PMD issues for class org.finra.jtaf.ewd.timer.WaitForConditionTimer #122

Open mmlinford opened 8 years ago

mmlinford commented 8 years ago

The following issues were found in org.finra.jtaf.ewd.timer.WaitForConditionTimer when running PMD:

[INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:31 Rule:ImmutableField Priority:3 Private field 'timerCallback' could be made final; it is only initialized in the declaration or constructor.. [INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:32 Rule:ImmutableField Priority:3 Private field 'locator' could be made final; it is only initialized in the declaration or constructor.. [INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:34 Rule:LoggerIsNotStaticFinal Priority:2 The Logger variable declaration does not contain the static and final modifiers. [INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer$ITimerCallback:65 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldnt explicitly throw java.lang.Exception. [INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer$ITimerCallback:65 Rule:UnusedModifier Priority:3 Avoid modifiers which are implied by the context. [INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:89 Rule:IfStmtsMustUseBraces Priority:3 Avoid using if statements without curly braces. [INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:93 Rule:PreserveStackTrace Priority:3 New exception is thrown in catch block, original stack trace may be lost. [INFO] PMD Failure: org.finra.jtaf.ewd.timer.WaitForConditionTimer:94 Rule:AvoidCatchingGenericException Priority:3 Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block.