search

FINRAOS / JTAF-ExtWebDriver

Extensions for WebDriver is an enhancement to the powerful WebDriver API, with robust features that keep your browser automation running smoothly. It includes a widget library, improved session management and extended functions over the existing WebDriver API.
http://finraos.github.io/JTAF-ExtWebDriver
Apache License 2.0
26 stars 49 forks source link

Findbugs fixes #134

Closed mikeastarb closed 8 years ago

mikeastarb commented 8 years ago

Apologies for the noise in the removal of extra white space.

This PR closes #103, closes #104, and closes #108

I'm open to suggestion on other, perhaps, better ways to do this, so please feel free to make suggestions.

mmlinford commented 8 years ago

Are there any more specific exceptions we could throw instead of just Exception? If not, could you create one? We might need to have a conversation about how to handle this since we're going to have to when we do more findbugs/PMD fixes.

mmlinford commented 8 years ago

We'll handle that generic Exception issue as part of #117

mikeastarb commented 8 years ago

Sounds good to me. I'm wasn't too sure what the convention is for our exception handling and digging around for best practices online only gets me as far as opinion wars between what should or shouldn't be checked and if those exceptions should be sub-classes or generics with messages. Do we have a guideline to help make that kind of call?

mmlinford commented 8 years ago

We do not have an established guideline. Right now EWD has a handful of specialized exceptions. I don't think it would hurt to add a few more, but I wouldn't want that number to explode eventually either. Let's talk about it at the next meeting.