search

FINRAOS / JTAF-ExtWebDriver

Extensions for WebDriver is an enhancement to the powerful WebDriver API, with robust features that keep your browser automation running smoothly. It includes a widget library, improved session management and extended functions over the existing WebDriver API.
http://finraos.github.io/JTAF-ExtWebDriver
Apache License 2.0
26 stars 49 forks source link

Added support for Flash plugin in Chrome #156

Closed knappk closed 6 years ago

knappk commented 6 years ago

By default, the Chrome webdriver disables all plugins. This code allows you to enable the Flash plugin if you desire, assuming it is already installed.

To enable the Flash plugin, add the following line to your chrome.properties file:

flash.enabled=true

This is a cherry-pick of commit d861c7c4238ac9f052d0c1383fce61b6f0d59b5a .

mmlinford commented 6 years ago

Cool! I might not have time to look at it personally for a couple days (going on vacation :-D ), but maybe @mikeastarb, @santiagos11, or @keanedj can take a look?

Also, @keanedj , isn't this what you said you needed a while ago?

mmlinford commented 6 years ago

@keanedj just said it seems to be working for him as well. Would it be possible to just right some unit tests for this?

keanedj commented 6 years ago

I lied. We need to update this commit to work for both local instances of Chrome, but also work for Chrome when using RemoteWebDriver for runs in Sauce Labs.

keanedj commented 6 years ago

I updated my EWD code locally to set these values before creating the remote webdriver and voila. Chrome latest working in sauce!!! I pulled the entire ChromeOptions out into it's own method and then called that method from both local and remote. I can create a pull request tomorrow or we can just update Kylen's.

knappk commented 6 years ago

@keanedj Merged in your suggested changes 😃