search

FINRAOS / JTAF-XCore

XCore is a framework to define and execute automated tests. It enables automation code development in Java, test script development in XML via domain specific language, and execution & reporting via JUnit.
http://finraos.github.io/JTAF-XCore/
Apache License 2.0
10 stars 17 forks source link

Checkstyle #83

Closed santiagos11 closed 8 years ago

santiagos11 commented 8 years ago

Running "mvn site" will generate checkstyle, PMD, and findbugs reports which are helpful.

I also suggest having all the artifact versions as properties in the pom.xml file. What do you guys think?

mmlinford commented 8 years ago

Adding the reporting plugins sounds good to me. I'm not against adding the artifact versions as properties, but I'm kind of curious as to what you think the main benefits would be. I've seen it done in some other projects, but haven't really had an problems in any of mine with just placing the version number right in the block. Off the top of my head I'm thinking the main benefits would be that you'd have a nice little section at the top of your POM that has all your versions right there rogether and that having them as properties would make it easier to re-use a value if multiple dependencies always had to have the same version or something. Is there anything else?

santiagos11 commented 8 years ago

There is nothing else really. You exactly described the situation.