search

FINRAOS / MSL

MSL (pronounced 'Missile') stands for Mock Service Layer. Our tools enable quick local deployment of your UI code on Node and mocking of your service layer for fast, targeted testing.
http://finraos.github.io/MSL/
Apache License 2.0
32 stars 24 forks source link

If you use double quotes as element locator, element methods in appcontainer-driver.js fails #67

Closed kood1 closed 9 years ago

kood1 commented 9 years ago

When getting element via locator, if you use double quotes the method fails to return the object since we are not escaping double quotes. We can either make it a requirement to use single quote or handle double quotes.

seoj commented 9 years ago

Mind if I starting taking a look at escaping the quotes?

kood1 commented 9 years ago

@seoj - please feel free to start working on this and submitting a PR! :-) Thanks!

seoj commented 9 years ago

For the eval() statements, instead of using eval() I was wondering if we could try something like this:

window.frames[0].$('body').append('Appended from parent');

Much safer to use than an eval() and more explicit. Any thoughts?

seoj commented 9 years ago

For now decided to simply escape the quotes. Seems like the suggestion may be more impacting.