FIRST-Tech-Challenge / FtcRobotController

BSD 3-Clause Clear License
686 stars 3.98k forks source link

Out-of-bounds access in libuvc #683

Open qwertychouskie opened 10 months ago

qwertychouskie commented 10 months ago

https://github.com/libuvc/libuvc/pull/211

Would be good to get this fix included in the SDK's copy of libuvc. We hit an intermittent low-level crash last season when using 3 cameras, and this seems to be the most likely cause.

Windwoes commented 10 months ago

The use of libuvc in the SDK does not include the uvc_yuyv2bgr() function to my knowledge, though I'd have to do a reference search to be sure. The raw yuyv or mjpeg buffer is handed to EasyOpenCV, where it is handed to either OpenCV to do the conversion to RGBA (in the case of yuy2) or to libjpeg-turbo (in the case of mjpeg).