search

FIRST-Tech-Challenge / scorekeeper

FIRST Tech Challenge Live Scorekeeper Software
89 stars 21 forks source link

Incorrect "Already Advancing" Calculations #247

Closed hightechkids closed 5 years ago

hightechkids commented 5 years ago

Both last week and this week, we've had team that previously advanced that were not marked as such in the advancement report. After we archive and shut down the system, the next time it come up, it is correct. Here an example from this weekend: Team 5962 is marked as advancing in team list

AdvanceReportA (picture of piece of paper) is what is generated at the qualifier. I went back and forth the re-display this many times, each time it came up with 5962 not being marked as advancing as Inspire winner. AdvanceReportB is what is generated after I archive, shut down and restart. So I'm unable to re-create the problem. Last week there were more issues, with a very confusing set of "Already Advancing" and Advancing above" and one team that didn't even show up on the advancing report at all.

I can pull all that out too, but it appears something is not being properly saved until shut down.

advancereportb teamlist advancereporta

adwiii commented 5 years ago

I have been able to reproduce the issue involving rebooting the server. I will continue to investigate.

Can you explain further what happened with the team that did not show up being present in the advancement report? Where they part of the rankings advancement or an award? Were they still listed in the team list for the event?

hightechkids commented 5 years ago

Here's what happened last week (along with the "already advancing" problem.)

We had a team that had already advanced. That did not win any awards and was not the winner/finalist alliance this week. They did not show up in the Advancement report at all. Nowhere.

I just pulled it up again and the problem still exists, I can send you the archive if you'd like. The picture is the team list - 10364 - Time Pilots is in the tournament, competed and is marked as already advancing. They were ranked 4th in qualifying matches, but their alliance lost in the semis. I think they should have shown up in the advancement report as 16 - highest ranked team not previously advanced. But the PDF of the advancement report does not have10364 listed anywhere.

Norm Tiedemann norm@hightechkids.org

On Mon, Dec 10, 2018 at 2:16 PM Trey Woodlief notifications@github.com wrote:

I have been able to reproduce the issue involving rebooting the server. I will continue to investigate.

Can you explain further what happened with the team that did not show up being present in the advancement report? Where they part of the rankings advancement or an award? Were they still listed in the team list for the event?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FIRST-Tech-Challenge/scorekeeper/issues/247#issuecomment-445957143, or mute the thread https://github.com/notifications/unsubscribe-auth/AqIMqShB0QxLcBPbrBUxDIPqYgvs4b5Nks5u3sEggaJpZM4ZMBTo .

adwiii commented 5 years ago

If they had previously advanced at another tournament as you indicated, then they do not show up in "highest ranked team not previously advanced" because even though they did not advance at this tournament they still are an advancing team. Since they advanced at a previous tournament, 10364 would only appear in the list if they won an award or were on the winning or finalist alliance.

hightechkids commented 5 years ago

Interesting. OK - Thanks. I don't remember seeing it this way in past years, but can't say I ever really checked.

I just assumed that all teams in the tournament would be listed. They would be shown in proper order and it would indicate "Already Advancing". I thought the "not already advancing" statement only applied to this tournament, but I see your point.

Thanks for explaining it. Good luck with the other problem. Norm T.

On Mon, Dec 10, 2018 at 2:57 PM Trey Woodlief notifications@github.com wrote:

If they had previously advanced at another tournament as you indicated, then they do not show up in "highest ranked team not previously advanced" because even though they did not advance at this tournament they still are an advancing team. Since they advanced at a previous tournament, 10364 would only appear in the list if they won an award or were on the winning or finalist alliance.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FIRST-Tech-Challenge/scorekeeper/issues/247#issuecomment-445969910, or mute the thread https://github.com/notifications/unsubscribe-auth/AqIMqdSI5INilkN1S2_7QPV0lt8wxxiZks5u3sqxgaJpZM4ZMBTo .

adwiii commented 5 years ago

The issue of "Already Advancing" not taking effect until the server has been rebooted has been fixed in v0.6.1