FIRST-Tech-Challenge / scorekeeper

FIRST Tech Challenge Live Scorekeeper Software
89 stars 21 forks source link

Data Submission Should Not Delete Awards #615

Open aj-foster opened 1 year ago

aj-foster commented 1 year ago

Today I caused an unforced error at an event. Ultimately it was my fault for not understanding the system and the required workflow, however the software has an opportunity to prevent this problem in the future.

Describe the bug When a hybrid event submits match data from the local scoring system to FIRST, awards data in FTC Scoring (cloud) will be deleted if not previously synced to the local instance.

To Reproduce Steps to reproduce the behavior:

  1. Create a hybrid League Tournament event.
  2. Setup the local scoring system for match play.
  3. Concurrent to match play, input awards information into FTC Scoring (cloud).
  4. Play matches.
  5. [Here is where you are supposed to sync cloud award information to the local scoring system. We did not do that.]
  6. Submit match data to FIRST via the Event Dashboard.

Expected behavior There are multiple options:

  1. Ideally, submitting match data from the local system would merge awards data with the cloud scoring. Submissions could be rejected if a merge was not possible (for example, if the same award was given to two different teams). In the event that the local system has no awards data, then nothing should change upon submission.
  2. Less than ideal, the submission should be rejected if the cloud scoring system has awards data but the local system has no data (or data that does not match).

Screenshots N/A

Device (please complete the following information): N/A

Additional context Again, I recognize that this was ultimately my failure by not syncing awards data to the local system before submitting data. However, given that it is possible to perform the entire awards ceremony from the cloud system, it stood to reason that we could submit match data, have the cloud system integrate that data into the advancement report, and present the awards using the built-in presentation feature from the cloud.

aj-foster commented 1 year ago

(Additional information asked on the conference call.)

This event occurred on 2/28/2023, in the Florida region, the Space Coast League Tournament — I believe the event code is USFLFLSPLT.