FIRST-Tech-Challenge / scorekeeper

FIRST Tech Challenge Live Scorekeeper Software
87 stars 21 forks source link

Setting No Robot doesn't override Team Prop #644

Closed jvens closed 11 months ago

jvens commented 11 months ago

Describe the bug If the refs enter that a team has a prop and also mark as not having a robot it will not let you submit final scrores.

To Reproduce Steps to reproduce the behavior:

  1. Go to Match Setup on the ref tablet
  2. Select Team Prop for the first team
  3. Set the team to No Robot (this will cause Team Prop to become disabled, but the backend keeps the Team Prop Setting)
  4. Set Alliance ready
  5. Run the entire match submitting Auto and Driver Controlled scores
  6. Click Submit Final Score
  7. Observe error message No-show Team cannot use Team Prop
  8. Also observe on the Active Match page Team Prop and NR are both checked

Expected behavior If a team is marked as no robot this should take precedents over the Team Prop setting. This is already the case in the UI on the Match Setup page, but the backend logic is not handling that case correctly.

Screenshots image

image

image

image

Device (please complete the following information):

Additional context I didn't test but I suspect this might also be an issue for no show teams, and possible other edge cases as well. One of our refs found this issue tonight when testing the tablets and I could see this coming up in a real event if a team has to pull their robot off the field last minute which has certainly happened in the past.

maths22 commented 11 months ago

This has been fixed in v5.0.7