FIRST-Tech-Challenge / scorekeeper

FIRST Tech Challenge Live Scorekeeper Software
87 stars 21 forks source link

Add Request LRI/LFI Table and Notifications #728

Open jvens opened 5 months ago

jvens commented 5 months ago

Is your feature request related to a problem? Please describe. The request LRI and request LFI feature that was added in for championship worked well (thanks @maths22 for adding it), but doesn't scale well to other events due to requiring slack integration. Also, we found messages could get lost on slack and it was hard to tell if someone was already responding to a request leading to multiple LRI's showing up at one teams pit at the same time.

Describe the solution you'd like A new page specifically for the LRIs to be able to see all of the requests that have been made. Each LRI Request should also have a status or way for an LRI to show that they are on their way to that request, and a way to see the history of request.

I envision a table where the columns are:

It might be possible to integrate this feature into the Robot Inspection Notes page and a filter since most of these columns already exist on that page.

In addition to that, it would be really nice if the tablets logged in with LRI permissions got a notification when a request is made. Ideally this would be through a Service Worker, but that would require a security certificate (#717) to work. But you could at least add a notification tray inside the page to show these messages, and handle the lifecycle of the notifications yourself.

Everywhere I said LRI above could also apply equally to LFI.

Describe alternatives you've considered What we did with Slack worked, although there was confusion over if issues needed to be submitted with the Request LRI button or in Slack directly, and there wasn't a universal agreed upon way to mark issues as resolved on slack. We can create processes that do this, but this seems like something that could be built into the FTC live software and may be useful at other large scale events besides the Championship.

Additional context N/A

rachmo commented 5 months ago

Would you consider reviewing the way Nexus uses slack for FRC if you aren't already aware? The CSA application I think is most similar to how this was set-up for our LRI/LFIs.

I agree for very small scale events Slack might never be the answers but for RCMP and CMP events a more refined slack based solution might still provide value, but I'd like to hear your feedback.