FISCO-BCOS / go-sdk

golang SDK of FISCO BCOS
Apache License 2.0
74 stars 58 forks source link

add unittest && change parseConfig interface #31

Closed sulenn closed 4 years ago

ghost commented 4 years ago

Warnings are found on analyzing the commit c974ca7.

1 warning:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

codecov-commenter commented 4 years ago

Codecov Report

Merging #31 into develop will increase coverage by 0.04%. The diff coverage is 38.67%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
+ Coverage    54.00%   54.04%   +0.04%     
===========================================
  Files           23       25       +2     
  Lines         1700     1817     +117     
===========================================
+ Hits           918      982      +64     
- Misses         647      680      +33     
- Partials       135      155      +20     
Impacted Files Coverage Δ
conf/parse_pem.go 60.37% <ø> (ø)
smcrypto/sm_crypto.go 47.88% <ø> (ø)
client/api_handler.go 54.87% <12.50%> (ø)
client/go_client.go 54.83% <28.57%> (ø)
conf/config.go 44.30% <40.29%> (ø)
precompiled/cns/cns_service.go 48.68% <41.17%> (ø)
precompiled/permission/permission_service.go 74.39% <50.00%> (ø)
precompiled/cns/cns_info.go 60.00% <60.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c8a446...c974ca7. Read the comment docs.

fisco-dev commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- precompiled/cns/cns_info.go  2
- conf/config_test.go  4
- conf/parse_pem.go  9
- conf/parse_pem_test.go  9
- client/api_handler.go  6
- client/go_client.go  11
- .ci/ethPrecompiled/bn256_gm.go  1
- .ci/ethPrecompiled/bn256.go  1

Complexity decreasing per file
==============================
+ conf/config.go  -1

See the complete overview on Codacy