FISCO-BCOS / go-sdk

golang SDK of FISCO BCOS
Apache License 2.0
74 stars 58 forks source link

add Interface of ContractLifrCycle Precompiled Contract #36

Closed sulenn closed 4 years ago

ghost commented 4 years ago

Warnings are found on analyzing the commit c3ebb60.

1 warning:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

codecov-commenter commented 4 years ago

Codecov Report

Merging #36 into develop will decrease coverage by 0.61%. The diff coverage is 45.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
- Coverage    52.86%   52.25%   -0.62%     
===========================================
  Files           27       29       +2     
  Lines         2143     2306     +163     
===========================================
+ Hits          1133     1205      +72     
- Misses         821      896      +75     
- Partials       189      205      +16     
Impacted Files Coverage Δ
...ecompiled/contractlifecycle/contract_life_cycle.go 38.55% <38.55%> (ø)
...d/contractlifecycle/contract_life_cycle_service.go 50.00% <50.00%> (ø)
...mpiled/chaingovernance/chain_governance_service.go 49.04% <100.00%> (ø)
precompiled/config/system_config_service.go 55.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89bd535...c3ebb60. Read the comment docs.

fisco-dev commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- precompiled/contractlifecycle/contract_life_cycle_service.go  8
- precompiled/contractlifecycle/contract_life_cycle.go  2
- precompiled/contractlifecycle/contract_life_cycle_test.go  4

Clones added
============
- precompiled/chaingovernance/chain_governance_service.go  5
- precompiled/contractlifecycle/contract_life_cycle_service.go  7
- precompiled/contractlifecycle/contract_life_cycle.go  7
- precompiled/chaingovernance/chain_governance_test.go  3
- precompiled/contractlifecycle/contract_life_cycle_test.go  5

See the complete overview on Codacy