ghost commented 4 years ago

Warnings are found on analyzing the commit d6a2653.

1 warning:

⚠️ Goodcheck

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

codecov-commenter commented 4 years ago

Codecov Report

Merging #40 into develop will increase coverage by 0.16%. The diff coverage is 57.00%.

@@             Coverage Diff             @@
##           develop      #40      +/-   ##
===========================================
+ Coverage    52.44%   52.60%   +0.16%     
===========================================
  Files           27       27              
  Lines         2418     2441      +23     
===========================================
+ Hits          1268     1284      +16     
- Misses         929      937       +8     
+ Partials       221      220       -1

Impacted Files	Coverage Δ
precompiled/crud/condition.go	`35.00% <ø> (ø)`
precompiled/crud/crud.go	`36.25% <47.36%> (+7.46%)`	:arrow_up:
precompiled/crud/crud_service.go	`49.05% <61.01%> (+1.63%)`	:arrow_up:
precompiled/permission/permission_service.go	`69.74% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e580740...034038f. Read the comment docs.

fisco-dev commented 4 years ago

Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- precompiled/crud/crud_service_test.go  1

Clones added
============
- precompiled/crud/crud_service_test.go  3
- precompiled/chaingovernance/chain_governance_test.go  5
- precompiled/permission/permission_service.go  1
- precompiled/contractlifecycle/contract_life_cycle_test.go  4
- precompiled/crud/crud_service.go  3

Clones removed
==============
+ precompiled/permission/permission_service_test.go  -1

See the complete overview on Codacy

FISCO-BCOS / go-sdk

refactor the interface of Crud Precompiled Contract #40

Codecov Report