FISCO-BCOS / go-sdk

golang SDK of FISCO BCOS
Apache License 2.0
73 stars 58 forks source link

add queryCNS command for CNS Precompiled Contract and update GetAddressByContractNameAndVersion interface #46

Closed sulenn closed 4 years ago

ghost commented 4 years ago

Warnings are found on analyzing the commit 4d032f8.

1 warning:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

codecov-commenter commented 4 years ago

Codecov Report

Merging #46 into develop will increase coverage by 0.28%. The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    52.64%   52.93%   +0.28%     
===========================================
  Files           27       27              
  Lines         2456     2439      -17     
===========================================
- Hits          1293     1291       -2     
+ Misses         940      929      -11     
+ Partials       223      219       -4     
Impacted Files Coverage Δ
precompiled/cns/cns_service.go 55.00% <60.00%> (+5.92%) :arrow_up:
precompiled/cns/cns.go 38.15% <63.63%> (+4.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1370bb6...4d032f8. Read the comment docs.

fisco-dev commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- cmd/commandline/cns.go  1

Complexity decreasing per file
==============================
+ precompiled/cns/cns_service.go  -5

Clones added
============
- precompiled/cns/cns.go  1

Clones removed
==============
+ precompiled/cns/cns_service.go  -2

See the complete overview on Codacy