search

FIT3170-FY-Project-7 / RABIT-COMMON

Common repository of the RABIT project, for documentation storage and cross-component interaction.
https://rabit2022.cloud.edu.au/plots
ISC License
3 stars 1 forks source link

[Bug] Nonexistent plot not handled gracefully #26

Closed megascrapper closed 1 year ago

megascrapper commented 1 year ago

Describe the bug

When you go to an invalid or nonexistent plot page (e.g./visualise/this-is-invalid), instead of showing a 404 page or error message it would just hang on Loading... for a few moment before the page would go blank.

Steps to reproduce

Go to a plot page that don't exist or is invalid, e.g. https://rabit2022.cloud.edu.au/visualise/this-is-invalid

Expected behaviour

Th should how a 404 page stating the page cannot be found.

Logs

TypeError: Cannot read properties of undefined (reading 'collection_title')
    at /home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:184:27
    at Generator.next (<anonymous>)
    at fulfilled (/home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: Cannot read properties of undefined (reading 'collection_title')
    at /home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:184:27
    at Generator.next (<anonymous>)
    at fulfilled (/home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: Cannot read properties of undefined (reading 'collection_title')
    at /home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:184:27
    at Generator.next (<anonymous>)
    at fulfilled (/home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
TypeError: Cannot read properties of undefined (reading 'collection_title')
    at /home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:184:27
    at Generator.next (<anonymous>)
    at fulfilled (/home/akbarfadi01/Documents/monash/2022/RABIT-COMMON/RABIT-BACKEND/src/RawData/RawDataController.ts:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Additional context

Tested on 6d93191 (frontend) and f1cee6b (backend) locally and on nectar instance as of 14 October.