FIWARE / context.Orion-LD

Context Broker and CEF building block for context data management which supports both the NGSI-LD and the NGSI-v2 APIs
https://www.etsi.org/deliver/etsi_gs/CIM/001_099/009/01.06.01_60/gs_CIM009v010601p.pdf
GNU Affero General Public License v3.0
49 stars 40 forks source link

patched some scripts to properly build the docker image #1568

Closed jicarretero closed 4 months ago

jicarretero commented 4 months ago

Proposed changes

I have modified some installation scripts for the docker, they have some issues which prevent them from properly building the docker image.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

This pull request only affects the Docker image generation. Nothing disruptive with the code here.

github-actions[bot] commented 4 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our [Contributor License Agreement]() before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheckcla in this Pull Request

kzangeli commented 4 months ago

So. we have a problem with permissions. Weird problem, as we haven't seen t before. So, I'm gonna go ahead and merge this PR even though it fails.

Why? Well, the PR fixes the BIG problem we had with the compilation of the base image. That's what's important.

Once merged, I'll play a little with it, see if I find out why we don't have enough permissions to push the base image. God knows I've been pushing "final" images to dockerhub/quay every day, a few times for years ...