search

FIWARE / helm-charts

:globe_with_meridians: Kubernetes HELM Charts for FIWARE Generic Enablers for provisioning scalable, production-ready powered-by-FIWARE installations based around NGSI Context Brokers and other components
MIT License
23 stars 30 forks source link

Update keyrock chart to 8.3.3 image #165

Closed bramk closed 1 year ago

bramk commented 1 year ago

Solves a ui bug where you can not add users to an organisation and possible more

bramk commented 1 year ago

HI @wistefan, thank you for the review and good catch. I have now update the .Chart.appVersion as well.

Not sure if you also want me to increase the .Chart.version? I guess it would become 0.6.1 and require an update to the README? Would be happy to try.

wistefan commented 1 year ago

HI @wistefan, thank you for the review and good catch. I have now update the .Chart.appVersion as well.

Not sure if you also want me to increase the .Chart.version? I guess it would become 0.6.1 and require an update to the README? Would be happy to try.

Hi, thanks for the update to appVersion, the more important one actually is the .Chart.version, it would break the release if its not updated.

bramk commented 1 year ago

Ok, update .Chart.version and the README.md to reflect the new versions!

Just to understand your process. Is every merge to main automatically released? Eg should #166 wait for this merge and then increment .Chart.version again or do you accumulate several changes before actually releasing?

wistefan commented 1 year ago

Ok, update .Chart.version and the README.md to reflect the new versions!

Just to understand your process. Is every merge to main automatically released? Eg should #166 wait for this merge and then increment .Chart.version again or do you accumulate several changes before actually releasing?

Hi, It needs to be a different one than in the other PR.