search

FIWARE / node-red-contrib-FIWARE_official

FIWARE-Node-Red integration supporting NGSI-LD
https://nodered.org/
Apache License 2.0
14 stars 9 forks source link

Node Transform #3

Closed BjarkeHou closed 5 years ago

BjarkeHou commented 5 years ago

First draft of the Transformer node. Only briefly tested, but seems to transform from v2 to LD.

jmcanterafonseca commented 5 years ago

@BjarkeHou in order to perform a last review you need to rebase (please do not merge), revise CI, ensure a green CI and also provide a couple of test cases for your Node.

BjarkeHou commented 5 years ago

@jmcanterafonseca Right, I'll have a look at it tomorrow.

jmcanterafonseca commented 5 years ago

@BjarkeHou I plan to release a v1.0 this week, so if you complete your PR your node will be part of that release as well.

thanks!

jmcanterafonseca commented 5 years ago

@BjarkeHou there are still conflics, can you rebase and solve the conflicts, that should be easy

jmcanterafonseca commented 5 years ago

a final thing that would make this PR perfect is adding the new Node to the list in the README

thanks!

jmcanterafonseca commented 5 years ago

works perfectly, great work! and nice vacation!