Closed dmabtrg closed 8 years ago
As this code modify the docker-entrypoint.sh
file of the image, the tests will fail until the code lands and Dockerhub build a new image.
The steps to reproduce the case locally is:
/docker/images
foldermake make tutorials.tourguide-app
/server
folder, and run the tests:grunt test
\ Note that you may run npm install
before being able to run grunt
@FiwareULPGC , let me know if you have any doubts!
We have created a new branch from develop and merge your PR to it. We followed the instructions but we were unable to finish the tests. Tests are frozen at
Provisioning TourGuide users, roles and permissions.
We tried the test suit three times and we waited more than 30 minutes for each of them.
I don't know why it gets stuck there... I've reproduce it again (build the image, run the tests in a clean branch) successfully
Maybe something related with the merge? To bring the changes what I did was, clone @dmabtrg repository, and then checkout the branch:
$ git clone https://github.com/dmabtrg/tutorials.TourGuide-App.git
$ cd tutorials.TourGuide-App
$ git checkout -b feature/keyrock-5.3.0 origin/feature/keyrock-5.3.0
Or if you have any guess why it could be failing please let me know! :)
We tried it again and now it works.
LGTM
This PR adds the keyrock 5.3.0 official docker image. This change depends on the new CLI scipt (#127 and #132), as some configuration steps must be done with it (keyrock provision and tourguide OAuth configuration).
Tests on travis may fail until those changes are merged.