FIWARE / tutorials.TourGuide-App

:mortar_board: FIWARE Tour Guide Application.
https://fiwaretourguide.readthedocs.io/
MIT License
17 stars 19 forks source link

Use keyrock 5.3.0 official docker image. #126

Closed dmabtrg closed 8 years ago

dmabtrg commented 8 years ago

This PR adds the keyrock 5.3.0 official docker image. This change depends on the new CLI scipt (#127 and #132), as some configuration steps must be done with it (keyrock provision and tourguide OAuth configuration).

Tests on travis may fail until those changes are merged.

albertinisg commented 8 years ago

As this code modify the docker-entrypoint.sh file of the image, the tests will fail until the code lands and Dockerhub build a new image.

The steps to reproduce the case locally is:

make make tutorials.tourguide-app
grunt test

\ Note that you may run npm install before being able to run grunt

@FiwareULPGC , let me know if you have any doubts!

FiwareULPGC commented 8 years ago

We have created a new branch from develop and merge your PR to it. We followed the instructions but we were unable to finish the tests. Tests are frozen at

Provisioning TourGuide users, roles and permissions.

tourguide-test-suite-frozen

We tried the test suit three times and we waited more than 30 minutes for each of them.

albertinisg commented 8 years ago

I don't know why it gets stuck there... I've reproduce it again (build the image, run the tests in a clean branch) successfully

screenshot from 2016-09-02 16-14-22

Maybe something related with the merge? To bring the changes what I did was, clone @dmabtrg repository, and then checkout the branch:

$ git clone https://github.com/dmabtrg/tutorials.TourGuide-App.git
$ cd tutorials.TourGuide-App
$ git checkout -b feature/keyrock-5.3.0 origin/feature/keyrock-5.3.0

Or if you have any guess why it could be failing please let me know! :)

FiwareULPGC commented 8 years ago

We tried it again and now it works.

LGTM