Increase intentionally hardcoded game size limit / Nintendont shuts down if game larger than 1.36GiB

FIX94 / Nintendont

A Wii Homebrew Project to play GC Games on Wii and vWii on Wii U

1.95k stars 324 forks source link

Increase intentionally hardcoded game size limit / Nintendont shuts down if game larger than 1.36GiB #1183

Open dreamsyntax opened 8 months ago

dreamsyntax commented 8 months ago

Nintendont intentionally shuts down if an ISO is larger than the standard max GameCube ISO size (1.36GiB)

GameCube homebrew, such as Swiss can support up to ~~1.90GiB~~ 3.00GiB (thanks Extrems) ISOs
Dolphin can support unlimited size
There are various game mods that ship their own Nintendont version to change this limiter to a larger size

Proposal: Make the mainline maximum size at minimum match with Swiss (3.00GiB), which allows for more compatibility with game mods that add additional content.

I'm intending to open a PR soon to do this, but am opening an issue in case there is a reason these changes have not been accepted in the past.

Update: PR opened: https://github.com/FIX94/Nintendont/pull/1213

Extrems commented 8 months ago

The current version of Swiss should work up to 4 GiB-1. If it doesn't then it's a bug.

dreamsyntax commented 8 months ago

The current version of Swiss should work up to 4 GiB-1. If it doesn't then it's a bug.

The only thing I can think of is in testing we added an extra singular blob of data and it worked up until the disc total reached 1.9GiB. Is there a maximum per-file size that breaks Swiss?

Extrems commented 7 months ago

You sure your tools aren't broken and aren't using 32-bit signed file offsets internally? I'm struggling to make an image this big.

dreamsyntax commented 7 months ago

You sure your tools aren't broken and aren't using 32-bit signed file offsets internally? I'm struggling to make an image this big.

I suppose I can't rule it out?

We just used Dolphin's FST/Extracted Format -> Convert... -> To ISO option in this testing Sometimes we also rebuild with GCIT to match 1:1 full size, but that would not apply here

Extrems commented 7 months ago

I finally had success and got a 3 GiB image working with no issues with the current version of Swiss.

dreamsyntax commented 4 months ago

Attaching an example of a Nintendont fork with the filesize limit exceeded, categorizing discs separately that meet this case: https://github.com/FIX94/Nintendont/compare/master...nfsman34:Nintendont-SonicRiders:master