search

FIX94 / Nintendont

A Wii Homebrew Project to play GC Games on Wii and vWii on Wii U
1.91k stars 323 forks source link

Sonic Adventure 2 widescreen broken and removed somewhere down the line #266

Open cheatfreak47 opened 8 years ago

cheatfreak47 commented 8 years ago

This is an oddity I noticed, ever since an update literally so long ago, I can't place a finger on it, SA2B's Widescreen broke, and ever since then, it now plays in 4:3, for a while I remember the game was crashing with the widescreen patch enabled, but it'd be nice if this could be restored to it's prior working state at some point.

As for what exactly caused it, I haven't a single clue.

GerbilSoft commented 8 years ago

I remember it working a while ago too, and as you mentioned, it does nothing now.

I'll try running a git bisect to see if I can narrow down the commit where it stopped working.

GerbilSoft commented 8 years ago

11443ee3eebda2e04f321459546adbcd780df465 is the first bad commit commit 11443ee3eebda2e04f321459546adbcd780df465 Author: fix94.1@gmail.com fix94.1@gmail.com@6acfca08-c3de-247c-4448-9f1a92385553 Date: Thu Feb 26 20:42:56 2015 +0000

-fixed some broken pad rumble code and added a missing pattern
-changed up some disc code, it should still work just like before, the only difference is that no actual disc drive needs to be in place to work from sd/usb
-added widescreen patch for super monkey ball

https://github.com/FIX94/Nintendont/commit/11443ee3eebda2e04f321459546adbcd780df465#diff-35ca334853fd2db5105796cc6119ff0a

Removing the change from PatchWidescreen.c in this commit fixes SA2B, but I assume it also breaks Super Monkey Ball.

@FIX94, any ideas on how to fix this for both SA2B and SMB?

EDIT: Bonus round: After reverting that patch and going to Stage Select, SA2B crashed with the infamous "buzz of death". I'm guessing it's writing over something that isn't actually an aspect ratio value.

FIX94 commented 8 years ago

well we would have to start hardcoding them for every game I guess since the chances appear to be high wrong addresses get interpreted as the right ones :(