Closed mgatny closed 2 years ago
First, I want to give credit to Greg Malatestinic who made the original contribution.
The namespace was changed when Orchestra v1.0 draft standard was published. "_2020" is correct.
Sort on a code is an optional attribute that represents its position in documentation. It was mistakenly made a string type in v1.0. There is a ticket and PR in fix-orchestra project to change it to numeric in v1.1 RC1.
Thanks, Don. And thank you, @gmala! This utility is fantastic, and really eases our adoption of orchestra!
@donmendelson, thank you for this utility. Being familiar with the quality of your work, I was thrilled to find out that it exists! I apologize in advance that my questions and/or proposed fixes in this PR could likely be answered by reading the complete orchestra spec...
Problem: I could not get orchestra2proto to run w/o errors
Solution: I switched the imports from
_2016
to_2020
, ensured that GroupRefType is considered before ComponentRefType (because GroupRefTypeis-a
ComponentRefType), and defaulted to using thevalue
attr when thesort
attr is not present.Observations/Questions:
sort
? This util assumes not.sort
ever differ fromvalue
? This PR assumes that ifsort
is omitted, thenvalue
should be used.Suspend
has asort
of4
(i.e. with a space). I assume this is a typo inOrchestraFIXLatest.xml
._2020
package is the right thing.