FIXTradingCommunity / fix-orchestra-protobuf

Translators from FIX Orchestra to the protobuf family of serializations
Apache License 2.0
14 stars 10 forks source link

fixup errors that occur post-repository2016 #13

Closed mgatny closed 2 years ago

mgatny commented 2 years ago

@donmendelson, thank you for this utility. Being familiar with the quality of your work, I was thrilled to find out that it exists! I apologize in advance that my questions and/or proposed fixes in this PR could likely be answered by reading the complete orchestra spec...

Problem: I could not get orchestra2proto to run w/o errors

Solution: I switched the imports from _2016 to _2020, ensured that GroupRefType is considered before ComponentRefType (because GroupRefType is-a ComponentRefType), and defaulted to using the value attr when the sort attr is not present.

Observations/Questions:

donmendelson commented 2 years ago

First, I want to give credit to Greg Malatestinic who made the original contribution.

The namespace was changed when Orchestra v1.0 draft standard was published. "_2020" is correct.

Sort on a code is an optional attribute that represents its position in documentation. It was mistakenly made a string type in v1.0. There is a ticket and PR in fix-orchestra project to change it to numeric in v1.1 RC1.

mgatny commented 2 years ago

Thanks, Don. And thank you, @gmala! This utility is fantastic, and really eases our adoption of orchestra!