FIXTradingCommunity / fix-orchestra

Machine readable rules of engagement
Apache License 2.0
71 stars 34 forks source link

[repository schema] Field type attribute does not distinguish between datatype and code set reference #170

Closed donmendelson closed 3 months ago

donmendelson commented 1 year ago

Comment by Emil Rakadjiev in Orchestra working group collaboration:

...based on our experience with developing tooling around Orchestra, it's awkward to handle in the code. It has also been a source of confusion within our development team several times. Which I think is a sign for a "code smell". Using a more explicit reference - mostly for the code set's scenario, but ideally also for whether it's a datatype or a code set - would be helpful in my opinion.

kleihan commented 1 year ago

Cleaner modelling to distinguish types from code sets explicitly. Conversion from v1.0 should be straightforward, changing type="xxxCodeSet" to codeSet="xxxCodeSet". Find instances with regular expression type=".*CodeSet"

kleihan commented 3 months ago

Implemented in RC1