search

FIXTradingCommunity / fix-orchestra

Machine readable rules of engagement
Apache License 2.0
71 stars 34 forks source link

[repository schema] Attribute group messageAttribGrp seems to be unused #189

Open kleihan opened 11 months ago

kleihan commented 11 months ago

The schema file repositoryTypes.xsd contains the following definition that does not seem to be used anywhere else. Please confirm whether this is obsolete and can be removed.

    <xs:attributeGroup name="messageAttribGrp">
        <xs:attribute name="msgType" type="fixr:MsgType_t"/>
        <xs:attribute name="category" type="fixr:Name_t"/>
        <xs:attribute name="abbrName" type="fixr:Name_t"/>
        <xs:attribute name="rendering" type="xs:string">
            <xs:annotation>
                <xs:documentation>A hint to processes about how to interpret the element. Not validated</xs:documentation>
            </xs:annotation>
        </xs:attribute>
    </xs:attributeGroup>

The message attributes msgType, category, abbrName are all part of the complex type messageType:

    <xs:complexType name="messageType">
                 ...
        <xs:attribute name="msgType" type="fixr:MsgType_t"/>
        <xs:attribute name="category" type="fixr:Name_t"/>
        <xs:attributeGroup ref="fixr:oidGrp"/>
                ...
    </xs:complexType>

The message attribute abbrName is part of the attribute group oidGrp inside the complex type messageType:

    <xs:attributeGroup name="oidGrp">
                 ...
        <xs:attribute name="abbrName" type="fixr:Name_t"/>
                 ...
    </xs:attributeGroup>

Only the rendering attribute is not defined for a message.

martinswanson commented 6 hours ago

Agree this is obsolete and can be removed in RC2.