[repository schema] Some categoryType's attributes should be required.

FIXTradingCommunity / fix-orchestra

Machine readable rules of engagement

Apache License 2.0

71 stars 34 forks source link

[repository schema] Some categoryType's attributes should be required. #191

Open francescoloconte opened 10 months ago

francescoloconte commented 10 months ago

The categoryType doesn’t have any required attributes. Seems like the name attribute should be marked as required, and maybe componentType too. For example, in FIX Basic XML format, the name, FIXMLFileName, and componentType are marked as required. The same issue found in sectionType.

francescoloconte commented 3 weeks ago

It would be useful to get feedback from the community about this change. Lacking that, @kleihan , what's your thoughts about this? If you supported it, I would create a PR for this. It would make the name and componentType attributes mandatory for both the categoryType and sectionType.