search

FIXTradingCommunity / fix-simple-binary-encoding

A FIX standard for binary message encoding
Other
261 stars 69 forks source link

Update 07example.md to not have presence in the type definitions #139

Closed hassila closed 2 years ago

hassila commented 3 years ago

I removed the presence field in the type definitions as they were removed for 2.0 to be field-only (which was a great change).

hassila commented 2 years ago

Hello? @kleihan or someone else?

kleihan commented 2 years ago

@hassila sorry for dropping the ball on this, We will review and merge. There has been very little activity on SBE v2.0 RC3 since quite a while.

hassila commented 2 years ago

Thanks @kleihan - saw your commits for ISO preparation and thought it worthwhile to ping.

kleihan commented 2 years ago

Thanks @kleihan - saw your commits for ISO preparation and thought it worthwhile to ping.

Note that the ISO submission will be SBE v1.0. Don has separated examples for proper validation into https://github.com/FIXTradingCommunity/fix-sbe-examples and these need to be reconciled into the spec.

hassila commented 2 years ago

@donmendelson thanks for clarification - I can see the issue for composites (although there’s some dissonance, as a systematic consistent approach would perhaps be to allow one to specify presence attributes for the subfields of the composite when declaring a composite field. Defining it on the type really just becomes a mechanism for defining constant as you say). Anyway, guess we can close this as such re-engineering is probably not worthwhile for what is a fringe case really. Thanks for your time.