FIXTradingCommunity / orchestrations

Service offerings expressed with Orchestra
Apache License 2.0
10 stars 7 forks source link

FixRepository44.xml contains a broken groupRef for 2085 #11

Closed GaryHughes closed 4 years ago

GaryHughes commented 4 years ago

The FIX Standard/FixRepository44.xml contains the the following references to group 2085 but no such group is defined.

<fixr:groupRef id="2085" added="FIX.4.4">
    <fixr:annotation>
        <fixr:documentation>
Number of repeating groups of historical "hop" information. Only applicable if OnBehalfOfCompID is used, however, its use is optional. Note that some market regulations or counterparties may require tracking of message hops.
        </fixr:documentation>
    </fixr:annotation>
</fixr:groupRef>
<fixr:component name="Hop" id="2085" category="Common" added="FIX.4.4" abbrName="Hop">
    <fixr:groupRef added="FIX.4.4" id="2085">
        <fixr:annotation>
            <fixr:documentation/>
        </fixr:annotation>
    </fixr:groupRef>
    <fixr:annotation>
        <fixr:documentation purpose="SYNOPSIS"/>
        <fixr:documentation purpose="ELABORATION"/>
    </fixr:annotation>
</fixr:component>
donmendelson commented 4 years ago

It looks like this should be <fixr:group name="Hop" instead of component. In FIX 5.0 it was apparently renamed HopGrp.

GaryHughes commented 4 years ago

Should I submit a PR to fix this directly or do these files get regenerated from from the 2010 repository?

donmendelson commented 4 years ago

@GaryHughes this issue should be sufficient. It will be fixed when the next EP is posted.

GaryHughes commented 4 years ago

Hi, it doesn't appear that this issue has been fixed in the EP258 update. There are several reference to group 2085, there is also a component 2085 but that just contains a group reference to the missing group as well.

donmendelson commented 4 years ago

I committed a correction to make "Hop" a repeating group. @GaryHughes can you please verify? (It was incorrectly marked as a non-repeating component in Unified Repository.)

GaryHughes commented 4 years ago

Confirmed fixed, thank you.