search

FIXTradingCommunity / orchestrations

Service offerings expressed with Orchestra
Apache License 2.0
10 stars 7 forks source link

codeSet name="SessionRejectReasonCodeSet" , incorrect name for id 373018 #25

Closed david-gibbs-ig closed 1 year ago

david-gibbs-ig commented 2 years ago

Name should be "NonDataValueIncludesFieldDelimiter", correcting this will help with code generation for QuickFIXJ

17419 </fixr:documentation> 17420 </fixr:annotation> 17421 </fixr:code> 17422 17423 17424 17425 Non "Data" value includes field delimiter (<SOH> character) 17426 </fixr:documentation>

donmendelson commented 2 years ago

The Orchestra file was created by translation from Unified Repository. In the source file, the enum name is also "Non".

kleihan commented 2 years ago

@david-gibbs-ig, this GitHub project only has the master for the Orchestra representations of the FIX legacy versions FIX 4.2 and FIX 4.4. The Orchestra representation for FIX Latest is only a copy from an internal source where it is currently generated out of an older repository format. A change of a symbolic name must also be made with the FIX standard Gap Analysis process.

Nonetheless, the issue raised can be seen as an error and should be fixed along with the symbolic name for value 19 that has a description "Invalid/Unsupported Application Version" and a symbolic name "Invalid". The plan is to add this change to the current Gap Analysis "Errors and Omissions 2021" that has been presented to the FIX GTC mid-December and will be made available for public review shortly.

As the field SessionRejectReason(373) already existed in FIX 4.2, a change of names must then also be applied to the Orchestra representations of the FIX legacy versions FIX 4.2 and FIX 4.4 in this GitHub project.

david-gibbs-ig commented 2 years ago

Thank you.

kleihan commented 2 years ago

SPEC-2605 added to internal Jira, planned for inclusion with EP271:


Symbolic names of two SessionRejectReason(373) values are very short, also compared to the other values. 
Code generators may struggle with such generic symbolic names.

Change symbolic name of 17="Non Data value includes field delimiter (<SOH> character)" as follows:
FROM: [Non]
TO: [NonDataValueIncludesFieldDelimiter]

Change symbolic name of 18="Invalid/Unsupported Application Version" as follows:
FROM: [Invalid]
TO: [InvalidUnsupportedApplVer]
kleihan commented 1 year ago

Resolved with EP271