michaelboyles
commented
1 year ago Thanks for the review. These were mostly auto-generated, I just eyeballed the changes and tweaked them. So I don't have strong feelings about the things you disagreed with changing.
I'll update as per your comments
@michaelboyles sorry for the delay, this is the first pull request we received for this and had to discuss our maintenance process for this and if we want to support this path at all. So far, we only offered the FIX discussion forum as a way for users to point to errors and omissions in (legacy) FIX versions, e.g. https://forum.fixtrading.org/t/fix-standard-errors-and-omissions-2022/16385. This would then feed into the standard process, e.g. https://forum.fixtrading.org/t/public-comment-period-fix-protocol-gap-analysis-errors-and-omissions-2022/17066. That can come with quite an overhead when it is only about simple typos.
Many thanks for the issues you identified in the Orchestra representations of the legacy FIX versions 4.2 and 4.4. We want to use it to enhance the quality of the text in the files. We reviewed your proposed changes and disagree with the general change from "whether" to "whether or not". We do not think this is material and in general try to avoid textual changes in the legacy versions as much possible. I will also make some specific comments inline.