FIXTradingCommunity / silverflash

Reference implementation of FIXP performance session layer
Apache License 2.0
25 stars 4 forks source link

Simple Open Framing Header #4

Closed plemanach closed 8 years ago

plemanach commented 9 years ago

Hello,

Is this implementation use Simple Open Framing Header ?

Regards,

Patrice

donmendelson commented 9 years ago

Currently, it is only using a message size prefix before the SBE header. I have Simple Open Framing Header listed on the Feature Roadmap in the project wiki. Do you think that feature should be prioritized? (Contributions to this project are welcome!)

plemanach commented 9 years ago

I would participate but I am more of a c# developer :) I think the framing is a key feature just to show that the encoding is plug-gable.

donmendelson commented 9 years ago

Agreed. Framing for inbound messages is already pluggable through

FixpSession.Builder.withMessageFramer(FrameSpliterator frameSpliter)

Two things are needed:

donmendelson commented 9 years ago

I moved this up in the feature road map to version 1.0.

plemanach commented 9 years ago

Thanks

donmendelson commented 9 years ago

Some ground rules, which should probably make there way into the FIXP spec: