[orchestra2md] Incorrect conversion of appinfo element for FIXML

FIXTradingCommunity / tablature

Easy authoring for rules of engagement using markdown

https://www.fixtrading.org/

Apache License 2.0

11 stars 8 forks source link

[orchestra2md] Incorrect conversion of appinfo element for FIXML #68

Open kleihan opened 2 years ago

kleihan commented 2 years ago

Tablature v1.0.2 does not process <fixr:appinfo purpose="FIXML"> correctly. It creates a column "Fixml" with content /P/[fixml:FIXMLencodingType: null]/P/ in markdown. Expected behavior is that it ignores such appinfo elements. They are not needed in markdown and are only for internal purposes to create the FIXML schemas.

donmendelson commented 2 years ago

No, appinfo is not just for internal use. It was intended that firms could extend their ROE with attributes of their own that are not predefined in Orchestra.

However, it would be possible to add a feature to suppress appinfo if desired.

kleihan commented 2 years ago

I was not precise enough when i said "such appinfo elements". I meant to say "appinfo elements with purpose FIXML". It is not about suppressing all appinfo elements. Tablature still has a problem with the conversion of appinfo that contains XML snippets it seems.

XML: <fixml:FIXMLencodingType notReqXML="1" /> MD: /P/[fixml:FIXMLencodingType: null]/P/

I do not expect to see "null" or square brackets. Is that intended?

kleihan commented 2 years ago

Suppress appinfo with purpose "FIXML" unless command line switch "--fixml" to show FIXML content (e.g. abbreviated names) is set.

donmendelson commented 2 years ago

An explanation for current ouput:

The fixml element contents actually consists of 3 XML nodes.
Invoking toString() results in a call to a Java library function to output a collection as a string. For each element, it outputs the node contents with type in brackets and any attributes, which in this case are null.