search

FJNR-inc / dry-rest-permissions

Rules based permissions for the Django Rest Framework
ISC License
75 stars 11 forks source link

Add type hints #21

Closed palfrey closed 2 years ago

palfrey commented 2 years ago

Fixes #18.

RignonNoel commented 2 years ago

Hi @palfrey and thanks again for this contribution!

There is a conflict on the .travis.yml due to your first pull-request i merged, can i invite you to rebase this pull-request to make sure your change are correct ?

I reviewed it and everything seems good for me, however i found some change between your two PR on the travis includes, on which documentation did you based your selection of DRF active support ? I did not find the equivalent of Django Support versions from their official documentation

Capture

palfrey commented 2 years ago

I reviewed it and everything seems good for me, however i found some change between your two PR on the travis includes, on which documentation did you based your selection of DRF active support ? I did not find the equivalent of Django Support versions from their official documentation

IIRC I think that was mostly based on a combination of digging around in various issues in DRF and seeing some build/install failures. I think the current set is all the compatible ones, but I might have gotten parts of it wrong.