search

FKlie / Predicata

GAP package Predicata: Deciding Presburger arithmetic using automata theory
http://www.algebra.uni-linz.ac.at/~kliemann/Predicata/
GNU General Public License v3.0
0 stars 1 forks source link

Some minor code simplications #10

Closed fingolfin closed 1 year ago

fingolfin commented 5 years ago

Note that the change to GetAlphabet slightly changes the order of the result. If that's a problem, it is trivial to adjust it to return the old order, I can quickly do it

In general, there are a bunch of other changes that IMHO should be made. For example, you seem to be using global functions in a lot of places where a property, attribute, category etc. would seem to be a better fit. Also, things like this are strange:

InstallGlobalFunction( IsPredicataTree, function( t )
    return(IsPredicataTreeObj(t));
end);

Why have such a function? Why not remove it, and rename IsPredicataTreeObj to IsPredicataTree?