Note that the change to GetAlphabet slightly changes the order of the result. If that's a problem, it is trivial to adjust it to return the old order, I can quickly do it
In general, there are a bunch of other changes that IMHO should be made. For example, you seem to be using global functions in a lot of places where a property, attribute, category etc. would seem to be a better fit. Also, things like this are strange:
InstallGlobalFunction( IsPredicataTree, function( t )
return(IsPredicataTreeObj(t));
end);
Why have such a function? Why not remove it, and rename IsPredicataTreeObj to IsPredicataTree?
Note that the change to
GetAlphabet
slightly changes the order of the result. If that's a problem, it is trivial to adjust it to return the old order, I can quickly do itIn general, there are a bunch of other changes that IMHO should be made. For example, you seem to be using global functions in a lot of places where a property, attribute, category etc. would seem to be a better fit. Also, things like this are strange:
Why have such a function? Why not remove it, and rename
IsPredicataTreeObj
toIsPredicataTree
?