fix order of MAPPO reshape in MPE & Hanabi

amacrutherford commented 5 months ago

also remove done masking in MPE as this doesn't seem to do anything. Instigated by #85

mttga commented 5 months ago

hey alex you inadvertently pushed your user in mappo_homogenous_rnn_hanabi.yaml. Same for start_wandb_sweep.py I guess?

amacrutherford commented 5 months ago

Yep am running the sweep on this branch, will clean it up before we merge :)

On Fri, 3 May 2024 at 08:17, mttga @.***> wrote:

hey alex you inadvertently pushed your user in mappo_homogenous_rnn_hanabi.yaml https://github.com/FLAIROx/JaxMARL/pull/87/files#diff-b204beb1b655085327a876984fe802f5bb58c1331d262420e7b8f185e746f711. Same for start_wandb_sweep.py I guess?

— Reply to this email directly, view it on GitHub https://github.com/FLAIROx/JaxMARL/pull/87#issuecomment-2092444800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP32SW3G5VCZCTAA2GJRIHDZAM2YBAVCNFSM6AAAAABG5IDD7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ2DIOBQGA . You are receiving this because you authored the thread.Message ID: @.***>

mttga commented 5 months ago

ah ok sweet :)

FLAIROx / JaxMARL

fix order of MAPPO reshape in MPE & Hanabi #87