search

FLAIROx / JaxMARL

Multi-Agent Reinforcement Learning with JAX
Apache License 2.0
393 stars 68 forks source link

Fix hint masking dimensions and restructure deck insertion. #96

Closed tindiz closed 2 months ago

tindiz commented 3 months ago

This will add the following two changes:

  1. Fixes dimension for masking when giving out hints. There was an issue when games were played with 3+ players since broadcasting wasn't possible in that case.
  2. Adds a utility function for inserting deck from (color, rank) pairs. Previously, we needed to one hot encode before inserting a deck, now we have another method of inserting the deck. This also led to small refactoring where we extract the one hot encoding into a protected func.
mttga commented 2 months ago

Hey Tin should we wait for all your changes before merging?

tindiz commented 2 months ago

Hey Tin should we wait for all your changes before merging?

Yes, working on it!

tindiz commented 2 months ago

Closing this, will open a new one when we are done.