search

FLAMEGPU / FLAMEGPU2

FLAME GPU 2 is a GPU accelerated agent based modelling framework for CUDA C++ and Python
https://flamegpu.com
MIT License
107 stars 22 forks source link

BugFix: ManyLinux CI was not setting BuildNumber inside generated bin #1036

Closed Robadob closed 1 year ago

Robadob commented 1 year ago

Fix the build number issue inside ManyLinux CI.

Also pre-emptively apply the fix to most of the other CI jobs (those which do compilation/CMake test)

Relates #1035

Error: image

Fixed version: (albeit the FLAMEGPU_VERSION_BUILDMETADATA: statement has been removed that was for debugging.)

image image

ptheywood commented 1 year ago

Tested the manylinux wheel generated by the pull_request triggered draft_ci workflow:

python3 -m pip install pyflamegpu-2.0.0rc1+cuda120-cp310-cp310-linux_x86_64.whl 
python3 -c "import pyflamegpu; print(pyflamegpu.VERSION_BUILDMETADATA)"
06b722f

The hash is the post-merge hash due to the pull_request triggger, but actual releases will behave as intended.