search

FLAMEGPU / FLAMEGPU2

FLAME GPU 2 is a GPU accelerated agent based modelling framework for CUDA C++ and Python
https://flamegpu.com
MIT License
99 stars 19 forks source link

Suppress Aarch64 GCC >= 10.1 warnings #1185

Closed ptheywood closed 4 months ago

ptheywood commented 4 months ago

Suppresses psABI warnings on aarch64 using GCC >= 10.1.

Unfortunately had to be applied project-wide as #pragma GCC diagnostic ignored "-Wpsabi" did not work (Attempt and reversion left in the PR for reference, but should be squash merged).

Closes #1176

ptheywood commented 4 months ago

Iirc, you added this processor arch to CI? (hard to check on my phone in parallel). So should be fine.

Not yet, we potentially can by emulating it with cmake cross compilation or QEMU that might allow us to make aarch python wheels, but that will take more time than I have right now (issue #1174).

I did make sure that I used the CMake var for the architecture that matches the target not the host during cross compilation too.

Robadob commented 4 months ago

Ah fair, well I assume you've tested it given the multiple commits

On Fri, 16 Feb 2024, 10:59 Peter Heywood, @.***> wrote:

Iirc, you added this processor arch to CI? (hard to check on my phone in parallel). So should be fine.

Not yet, we potentially can by emulating it with QEMU that might allow us to make aarch python wheels, but that will take more time than I have right now (issue #1174 https://github.com/FLAMEGPU/FLAMEGPU2/issues/1174)

— Reply to this email directly, view it on GitHub https://github.com/FLAMEGPU/FLAMEGPU2/pull/1185#issuecomment-1948180128, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVGCXDKDZJWYHPOMFGEITYT43YLAVCNFSM6AAAAABDKUUONSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBYGE4DAMJSHA . You are receiving this because your review was requested.Message ID: @.***>

ptheywood commented 4 months ago

Yep, tested manually on a grace-hopper node, with 2 versions of GCC.