FLEXIcontent / flexicontent-cck

Advanced content management for Joomla
http://www.flexicontent.org
82 stars 53 forks source link

Adding less to css compilation on update #1010

Closed micker closed 3 years ago

micker commented 3 years ago

Hello when we use flexicontent update we lost less customisation, we need to edit one template and save to regenerate it it can be cool to add less->css compilation on postinstall action

ggppdk commented 3 years ago

I think we don't need to change anything

If i understand you The CORE LESS files and the LESS files of core templates must never be customized.

If someone needs a customization then the user can create a CSS override in its own CSS files

About less re-compile in your development website (if you have not done already) You only need to turn on (auto) re-compile LESS in "Advanced" TAB of component options (It costs very little as it check modification times but for live sites it does not need to be turned ON)

Then if you visit a backend and a frontend view the dependent CSS files will be auto-created Thus your commits to GitHub will always contain the updated files

micker commented 3 years ago

But if user use less option in core template (no code juste option) the less files are updated and customisation lost We need to édit template template admin and save to regenerate good less customisation

iamrobert commented 3 years ago

J4 has shifted to Sass, and doesn't include a LESS compiler:

https://github.com/joomla/joomla-cms/issues/30569

TEMPLATES:

micker commented 3 years ago

Yes maybe for next version WE will study it Can you help us to prépare bs5 update for all templates ? WE will unify HTML and HTML5 file and update all styles

micker commented 3 years ago

more explain Before update image

After update image

After resave template image

in a prod site, or maybe we need to check is less compilation is correctly configure for prod at first

ggppdk commented 3 years ago

We do not use the LESS compiler of Joomla 3 instead we have a new version of the LESS compiler

so the removal of it in J4 is not a problem

ggppdk commented 3 years ago

-- Regarding CORE Less files The package already comes with THEM compiled to CSS, so we do not need to do anything on update,

-- Regarding LESS files of custom templates (e.g. item.less and category.less) When these include LESS variable files that are contained in the package, then these will be re-compiled due to package LESS files having newer date so we do not need to do something here either

right ?

ggppdk commented 3 years ago

Furthermore for developers doing changes to CORE LESS files, -- they need to enable the auto-compile of CORE LESS files in component configuration

So i don't think we have any issue with LESS compilation I am closing the issue, if there is some reason to open it , please respond and i will reopen it