Open Caenen opened 1 year ago
Created https://github.com/BC46/freelancer-hd-edition/pull/200 and https://github.com/BC46/freelancer-hd-edition/pull/201
I also noticed the sun death zone center points in both systems are very slightly off the origin each, which I'm not fixing because it does not practically matter. It's just yet another oddity with these two; all other death zones I've been looking at are centered on their star's exact coordinate.
Dumping some notes I took for a related project:
On sizes of suns:
Table of Vanilla sun sizes for reference # | sun_model | atmosphere | death zone 8 | 2000 | 11000 | 10000 1 | 2000 | 9000 | 8000 2 | 1000 | 9000 | 8000 3 | 1000 | 11000 | 10000 2 | 2000 | 8000 | 7000 1 | 2000 | 20000 | 15000 1 | 1000 | 5000 | 4000 3 | 1000 | 8000 | 7000 3 | 2000 | 7000 | 6000 2 | 1000 | 7000 | 6000 1 | 2000 | 10000 | 9000 2 | 2000 | 13000 | 12000 2 | 2000 | 4000 | 3000 1 | 1000 | 6000 | 5000 3 | 2000 | 12000 | 11000 2 | 1000 | 12000 | 11000 1 | 2000 | 12000 | 12000 1 | 1000 | 14000 | 13000 1 | 2000 | 14000 | 13000
Bugged suns and other notes: Bw05, Bw06, Bw07, Iw01, Iw02, Iw04, Ku03, Ku05: sun death zones are very slightly offset from the sun (which is usually at 0, 0, 0) A few systems have the sun death zone denoted as _death_sun rather than _sun_death
Br02: 1000 damage Br04: weird namescheme and 2000000 damage (originated as fix for missing death zone?) Bw05: sigma 13's nebula exclusions for the suns are weird. Sun1 has 5000 atmosophere and 9000 exclusion zone radius, Sun2 has 8000 atmosphere and 8000 exclusion zone radius Bw06 and Ew01: systems with multiple suns typically follow a "sun1, sun2, ..." pattern but the big Sigma 17 sun and the center Tau-37 sun do not have a number in the object and death zone names Bw10: sun asteroid exclusion is same as atmosphere range. No wonder autopilot has issues in this part of the system. Ew01: sun atmosphere and death zone radiuses are very small compared to their model size Iw01: sun atmosphere range is missing, death zone damage is only 100 Iw02: sun atmosphere range is missing, death zone is very small compared to sun model size Ku03: suns are enumerated the other way around than their positions/death zones Li02: sun atmosphere and death zone have the same radius
Ignoring suns of inaccessible and Unknown systems for these notes
Created #202 for the issues noted for Br02, Br04, Li02. Damage zones applying to your ship is handled serverside anyway so there is no conflict there.
Whether I should adress any of the other points I outlined is up for discussion, those are a little less clear-cut. I'm interested in feedback on those.
Iw01's sun death zone only deals 100 damage per half-second, and Iw02's sun death zone deals 10000 damage, which does not kill high level player ships instantly but melts them very quickly when their autopilot moves them through the zone, since there is no atmosphere defined for it to avoid either of these.
Iw02 (Hudson)'s sun death zone is particularly perplexing since it has SEVERAL mission vignettes overlap into it, and the destroy zone is small (5000) compared to the 2000 radius star model, which feels very wrong in gameplay. Raising the death zone radius and my solution to the atmosphere range might exacerbate issues for random missions in Iw02 for this reason and I'm not moving the mission vignettes at this time, a second review on Iw02 may be ideal.