search

FLHDE / freelancer-hd-edition

Freelancer: HD Edition is a mod that aims to improve every aspect of the game Freelancer (2003) while keeping the look and feel as close to vanilla as possible.
https://www.moddb.com/mods/freelancer-hd-edition
182 stars 15 forks source link

Restore Omicron Gamma's sun appearance to vanilla #245

Closed Ormuni closed 2 months ago

Ormuni commented 2 months ago

Omicron Gamma's sun has spines that make it look noticeably different from vanilla, where it appeared as an orange circle with no spines like the Red Giant in Omega-11. This is because JFLP gave every sun in stararch a spines entry to suppress a warning. The spines also don't blend well with the circle texture.

Adding a custom spines entry with all the values set to 0 to sm_red_sun removes the spines and did not appear to generate any errors or graphical glitches. If that does turn out to be problematic for some reason, a spines entry with an invisible texture could also work.

[spines] nickname = no_spines radius_scale = 0 shape = stripe_narrow min_radius = 0 max_radius = 0 spine = 0, 0, 0, 0, 0, 0, 0, 0, 0

This probably also affects other circle-type suns, but since they are all inside fields the spines normally never appear.

2024-09-16_14-52-52 2024-09-16_14-52-46

BC46 commented 2 months ago

Good find! I opted for the dummy spines approach as this requires fewer changes overall. Also since we don't want any spines, we can omit the spine value completely, which also makes radius_scale obsolete as it won't be used in this case. Moreover, some existing spines entries don't specify min_radius and max_radius, so I don't think we need those either.